Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarCloud PR Analysis #9123

Merged
merged 1 commit into from
Feb 13, 2025
Merged

SonarCloud PR Analysis #9123

merged 1 commit into from
Feb 13, 2025

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Feb 5, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Add a workflow that triggers a SonarQube Cloud Pull Request analysis on all PR targetting develop

Demo

Mobile Only (14 minutes to run)

Screenshot 2025-02-12 at 10 46 29 Screenshot 2025-02-12 at 10 47 48

Mobile and Desktop (24 minutes to run)

Screenshot 2025-02-12 at 10 49 08

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 3:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 3:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 3:02pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 3:02pm

@live-github-bot live-github-bot bot added automation CI/CD stuff mobile Has changes in LLM desktop Has changes in LLD and removed desktop Has changes in LLD labels Feb 5, 2025
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review February 12, 2025 08:55
@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner February 12, 2025 08:55
@cgrellard-ledger cgrellard-ledger force-pushed the feat/sonarcloud-pr-analysis branch from dc424c7 to 92470e3 Compare February 12, 2025 09:04
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Feb 12, 2025
@cgrellard-ledger cgrellard-ledger changed the title 👷 WIP - SonarCloud PR Analysis SonarCloud PR Analysis Feb 12, 2025
themooneer
themooneer reviewed Feb 12, 2025
View reviewed changes
.github/workflows/pr-analysis.yml Outdated
run: |
pnpm i --filter="live-mobile..." --filter="ledger-live" --no-frozen-lockfile --unsafe-perm

- name: Build desktop dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to build deps for LLM and LLD ? sonar analyzer don't need these deps imo .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to build them before running the tests below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then you can compact them under the installation process while they share the same condition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right 👍

themooneer
themooneer reviewed Feb 12, 2025
View reviewed changes
.github/workflows/pr-analysis.yml Outdated
run: |
cat apps/ledger-live-desktop/coverage/lcov.info apps/ledger-live-mobile/coverage/lcov.info > ./lcov.info

- name: Copy test execution files for LLD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this on LLD unit test generation

themooneer
themooneer reviewed Feb 12, 2025
View reviewed changes
.github/workflows/pr-analysis.yml Outdated
run: |
cat apps/ledger-live-desktop/coverage/lld-sonar-executionTests-report.xml > ./lld-sonar-executionTests-report.xml

- name: Copy test execution files for LLM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this on LLM unit test generation

@cgrellard-ledger cgrellard-ledger force-pushed the feat/sonarcloud-pr-analysis branch 2 times, most recently from dc50914 to 30a6583 Compare February 12, 2025 11:32
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 12, 2025
themooneer
themooneer reviewed Feb 12, 2025
View reviewed changes
apps/ledger-live-desktop/test Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to delete i guess. (i think you test with it so you can resolve my thread once done)

@cgrellard-ledger cgrellard-ledger force-pushed the feat/sonarcloud-pr-analysis branch 3 times, most recently from 621746b to f4b2cb1 Compare February 12, 2025 13:22
@live-github-bot live-github-bot bot added mobile Has changes in LLM and removed desktop Has changes in LLD labels Feb 12, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cgrellard-ledger cgrellard-ledger force-pushed the feat/sonarcloud-pr-analysis branch from f4b2cb1 to b007949 Compare February 12, 2025 15:01
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Feb 12, 2025
themooneer
themooneer approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work for a v1

@cgrellard-ledger cgrellard-ledger added this pull request to the merge queue Feb 13, 2025
Merged via the queue into develop with commit 235155c Feb 13, 2025
37 of 38 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/sonarcloud-pr-analysis branch February 13, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
automation CI/CD stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrellard-ledger @themooneer